From e101070851e35fabc6bdc8a60f7751d66a4558cb Mon Sep 17 00:00:00 2001 From: John Costa Date: Sat, 5 Apr 2025 14:59:50 +0100 Subject: [PATCH] refactor(tools): removing pointer map This is not needed --- backend/agents/client/client.go | 2 +- backend/agents/client/tools.go | 8 ++++---- backend/agents/client/tools_test.go | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/backend/agents/client/client.go b/backend/agents/client/client.go index a49c86d..3964aca 100644 --- a/backend/agents/client/client.go +++ b/backend/agents/client/client.go @@ -204,7 +204,7 @@ func CreateAgentClient(prompt string) (AgentClient, error) { }, ToolHandler: ToolsHandlers{ - handlers: &map[string]ToolHandler{}, + handlers: map[string]ToolHandler{}, }, }, nil } diff --git a/backend/agents/client/tools.go b/backend/agents/client/tools.go index 193fe92..a994363 100644 --- a/backend/agents/client/tools.go +++ b/backend/agents/client/tools.go @@ -17,7 +17,7 @@ type ToolHandler struct { } type ToolsHandlers struct { - handlers *map[string]ToolHandler + handlers map[string]ToolHandler } var NoToolCallError = errors.New("An assistant tool call with no tool calls was provided.") @@ -33,7 +33,7 @@ func (handler ToolsHandlers) Handle(info ToolHandlerInfo, toolCallMessage AgentA fnName := toolCall.Function.Name arguments := toolCall.Function.Arguments - fnHandler, exists := (*handler.handlers)[fnName] + fnHandler, exists := handler.handlers[fnName] if !exists { return []AgentTextMessage{}, errors.New("Could not find tool with this name.") } @@ -58,8 +58,8 @@ func (handler ToolsHandlers) Handle(info ToolHandlerInfo, toolCallMessage AgentA return responses, nil } -func (handler ToolsHandlers) AddTool(name string, fn func(info ToolHandlerInfo, args string, call ToolCall) (any, error)) { - (*handler.handlers)[name] = ToolHandler{ +func (handler *ToolsHandlers) AddTool(name string, fn func(info ToolHandlerInfo, args string, call ToolCall) (any, error)) { + handler.handlers[name] = ToolHandler{ Fn: func(info ToolHandlerInfo, args string, call ToolCall) (string, error) { res, err := fn(info, args, call) if err != nil { diff --git a/backend/agents/client/tools_test.go b/backend/agents/client/tools_test.go index cb07ece..f20973b 100644 --- a/backend/agents/client/tools_test.go +++ b/backend/agents/client/tools_test.go @@ -16,7 +16,7 @@ type ToolTestSuite struct { func (suite *ToolTestSuite) SetupTest() { suite.handler = ToolsHandlers{ - handlers: &map[string]ToolHandler{}, + handlers: map[string]ToolHandler{}, } suite.handler.AddTool("a", func(info ToolHandlerInfo, args string, call ToolCall) (any, error) {